Dan Kenigsberg has posted comments on this change.
Change subject: add emulator pin support to create vm
......................................................................
Patch Set 11: (2 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2012-12-20 15:49:56 +0800
Line 6:
Line 7: add emulator pin support to create vm
Line 8:
Line 9: move cpupin to a seperate function 'appendTunable'
I'm not sure I understand. <emulator pin> means that qemu general threads are
pinned to the specified cpu? If that's true, please say so in a revised commit
message. Stating the motivation (keep other cpu free for privileged guests)
would make sense, too.
Line 10: to add cputune(e.g.cpu_share),memtune limit def when create vm.
Line 11: add emulator pin support to create vm,
Line 12: then the cpuPinning dict changs to be:
Line 13: {0:'1-4','emulator':'2'}
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2454: # Since: 4.10.0
Line 2455: ##
Line 2456: {'type': 'VmDefinition',
Line 2457: 'data': {'acpiEnable': 'bool', 'clientIp': 'str', 'cpuType': 'str',
Line 2458: '*cpuPinning': 'StringMap', 'custom': 'StringMap',
I would very much prefer that you give a proper definition of cpuPinning.
An opaque StingMap may be good for user-defined custom properties. But it is
not enough for an object with structure.
Line 2459: 'devices': ['VmDevice'], 'display': 'VmDisplayType',
Line 2460: 'displayIp': 'str', 'displayPort': 'uint',
Line 2461: 'displaySecurePort': 'uint', 'emulatedMachine': 'str',
Line 2462: 'keyboardLayout': 'str', 'kvmEnable': 'bool', 'memSize':
'uint',
--
To view, visit http://gerrit.ovirt.org/8411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic616b825eca94682e1563ab51773d8a23351998d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
