Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File vdsm/storage/volume.py
Line 868: volume to the VM in a different way than the standard 'path'
way.
Line 869: """
Line 870: # By default, send path
Line 871: return {'volType': VmVolumeInfo.TYPE_PATH,
Line 872: 'path': self.getVolumePath()}
Another reason, I was also not sure if in future consumers of prepareImage
might still expect ['path'] to be the path in the domain. if we remove that,
derived class might change vmVolInfo['path'] and that can break assumptions of
prepareImage consumers. To be safe for past and future users, and for reasons
mentioned above, i still feel path is needed in both places.
Line 873:
Line 874: def getMetaParam(self, key):
Line 875: """
Line 876: Get a value of a specific key
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
