Federico Simoncelli has posted comments on this change. Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 13: I would prefer that you didn't submit this (1 inline comment) Minor issue. The rest looks fine to me. .................................................... File vdsm/storage/glusterSD.py Line 18: return glusterVolume.GlusterVolume Line 19: Line 20: @staticmethod Line 21: def findDomainPath(sdUUID): Line 22: glusterDomPath = os.path.join(sd.GLUSTERSD_DIR + "/*") I don't understand this change. My previous comment was about using os.path.join to build the path: os.path.join(GLUSTERSD_DIR, "*") Line 23: for tmpSdUUID, domainPath in fileSD.scanDomains(glusterDomPath): Line 24: if tmpSdUUID == sdUUID and mount.isMounted(os.path.join(domainPath, Line 25: "..")): Line 26: return domainPath -- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
