Federico Simoncelli has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/storage/fileSD.py Line 133: self.remotePath = os.path.basename(self.mountpoint) Line 134: self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA, Line 135: sd.METADATA) Line 136: Line 137: self.validateFileSystemFeatures() This check probably belongs both to the domain creation and startSpm (StoragePool). I still don't see the point for (all) the HSMs to check it. Line 138: Line 139: metadata = FileSDMetadata(self.metafile) Line 140: sdUUID = metadata[sd.DMDK_SDUUID] Line 141: domaindir = os.path.join(self.mountpoint, sdUUID) -- To view, visit http://gerrit.ovirt.org/9749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: humble devassy <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
