Mark Wu has posted comments on this change. Change subject: Extract bonding options building into a separate function. ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1428: # If the new added network was created on top of Line 1429: # existing bond, we need to keep the bond on rollback Line 1430: # flow, else we will break the new created bond. Line 1431: delNetwork(network, force=True, Line 1432: implicitBonding=networks[network]['bonding'] Good catch! I will fix it in next patch. Thanks! I was focusing the bonding case too much and neglecting the non-bonding case. It seems we need a comprehensive functional testsuite for network configuration. So, Toni, do you know any functional test cases based on vdsm api or engine rest api? Line 1433: in bondings) Line 1434: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION, Line 1435: 'connectivity check failed') Line 1436: except: -- To view, visit http://gerrit.ovirt.org/8885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
