Antoni Segura Puimedon has posted comments on this change.
Change subject: Extract bonding options building into a separate function.
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 1314: def _buildBondOptions(bondName, bondings):
Line 1315: logger = logging.getLogger("_buildBondOptions")
Line 1316:
Line 1317: # We need to use the newest host info
Line 1318: _ni = netinfo.NetInfo()
I think it is a good idea to rebase this patch on one that does away with the
different netinfo instance per method.
On the other matter. There is indeed a change of semantics that troubled me
when I first reviewed it and I tried quite a few of scenarios (with the last
fix I proposed) to see if it broke something. I tend to agree that this patch
would be much easier to take in if it would not do this semantics change, and
if necessary that would stand on its own patch.
Line 1319:
Line 1320: bond = {}
Line 1321: if bondings.get(bondName):
Line 1322: bond['nics'] = bondings[bondName]['nics']
Line 1428: # If the new added network was created on
top of
Line 1429: # existing bond, we need to keep the bond on
rollback
Line 1430: # flow, else we will break the new created
bond.
Line 1431: delNetwork(network, force=True,
Line 1432: implicitBonding=networks[network].
Maybe adding the condition that it should be also in networksAdded.
Line 1433: get('bonding') in bondings)
Line 1434: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION,
Line 1435: 'connectivity check
failed')
Line 1436: except:
--
To view, visit http://gerrit.ovirt.org/8885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
