Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1659: vnicXML.toprettyxml(encoding='utf-8'),
Line 1660: exc_info=True)
Line 1661: raise SetLinkAndNetworkError(e.message)
Line 1662: yield
Line 1663: except Exception:
True. I think that it may be desired in this case, but at least not in this
patch.
Line 1664: # Rollback link and network.
Line 1665: self.log.debug('Rolling back link and net for: %s',
dev.alias,
Line 1666: exc_info=True)
Line 1667:
self._dom.updateDeviceFlags(vnicXMLBackup.toxml(encoding='utf-8'),
--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
