Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 538: misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Line 539: path = lvm.lvPath(vgName, sd.OUTBOX)
Line 540: misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Line 541: except se.ActionStopped:
Line 542: raise
Remove this too?
Line 543: except se.StorageException:
Line 544: raise se.VolumesZeroingError(path)
Line 545:
Line 546: if version in VERS_METADATA_LV:
--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
