Mark Wu has posted comments on this change.
Change subject: Simplify netinfo get.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/netinfo.py
Line 283: else:
Line 284: # ovirt-engine-3.1 expects to see the "interface"
attribute iff the
Line 285: # network is bridgeless. Please remove the attribute and
this
Line 286: # comment when the version is no longer supported.
Line 287: data['interface'] = net
the 'interface' attribute represents the actual network interface name, not the
libvirt network name. For bridged network, they're the same if ignoring the
prefix 'vdsm-'. But for bridgeless network, it's different. So I think it's
wrong. The same problem exists in line 288, 'iface' for bridgeless network.
Line 288: data.update({'iface': net, 'bridged': False,
Line 289: 'addr': getaddr(net), 'netmask': getnetmask(net),
Line 290: 'gateway': routes.get(net, '0.0.0.0'),
Line 291: 'mtu': getMtu(net)})
Line 284: # ovirt-engine-3.1 expects to see the "interface"
attribute iff the
Line 285: # network is bridgeless. Please remove the attribute and
this
Line 286: # comment when the version is no longer supported.
Line 287: data['interface'] = net
Line 288: data.update({'iface': net, 'bridged': False,
why is 'bridged' also False for bridged network?
Line 289: 'addr': getaddr(net), 'netmask': getnetmask(net),
Line 290: 'gateway': routes.get(net, '0.0.0.0'),
Line 291: 'mtu': getMtu(net)})
Line 292: return data
--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
