Mark Wu has posted comments on this change.
Change subject: Simplify netinfo get.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/netinfo.py
Line 292: return data
Line 293: except OSError as e:
Line 294: if e.errno == errno.ENOENT:
Line 295: logging.info('Obtaining info for net %s.', net,
exc_info=True)
Line 296: raise KeyError('Network %s was not found')
It seems that we don't we need handle the exception here. Instead, we can just
leave it to the caller, get(). Then you needn't consider to re-raise the
exception.
Line 297: else:
Line 298: raise
Line 299:
Line 300:
--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
