Mark Wu has posted comments on this change. Change subject: Remove innecessary netinfo instance creation. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/netinfo.py Line 488: self.networks[network] = getNetData( Line 489: network, self.networks[network]['bridged'], getRoutes()) Line 490: except KeyError: Line 491: del self.networks[network] Line 492: raise so updateNetwork is only allowed to call after the network is changed, but not deleted? Probably we need a delNetwork function for netinfo if we would like reduce the instantiation of it. Now I see how it's used in configNetwork. I prefer to differentiate delNetwork from the updateNetwork. We can simply delete the network key in networks instead of fetching info from libvirt for delNetwork Line 493: Line 494: def updateBonds(self): Line 495: self.bondings = dict([(bond, Line 490: except KeyError: Line 491: del self.networks[network] Line 492: raise Line 493: Line 494: def updateBonds(self): why not allow to just update a given bond or a given list of bonds? Line 495: self.bondings = dict([(bond, -- To view, visit http://gerrit.ovirt.org/11082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cef02dc89d927799bf92d36b790598707583195 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
