Antoni Segura Puimedon has posted comments on this change. Change subject: Remove innecessary netinfo instance creation. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/netinfo.py Line 520: try: Line 521: self.bondings[bond] = getBondData(bond) Line 522: except KeyError: Line 523: if bond in self.bondings: Line 524: del self.bondings[bond] This one doesn't raise, in contrast to updateNetwork() because we want it to update all the bonds if called with several. I guess it could potentially check if len(bonds) is 1 and throw then, but I'm not convinced of the usefulness of that. -- To view, visit http://gerrit.ovirt.org/11082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cef02dc89d927799bf92d36b790598707583195 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
