Vinzenz Feenstra has posted comments on this change.
Change subject: Remove redundant exception assignations.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 536: misc.ddCopy("/dev/zero", path, RESERVED_METADATA_SIZE)
Line 537: path = lvm.lvPath(vgName, sd.INBOX)
Line 538: misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Line 539: path = lvm.lvPath(vgName, sd.OUTBOX)
Line 540: misc.ddCopy("/dev/zero", path, RESERVED_MAILBOX_SIZE)
Well guys, what's the problem? This is doing absolutely nothing. It's catching
an exception and rethrows it without doing anything. There's no reason what so
ever to keep this 'except'
If you want to ensure that this is somewhere mentioned that it can throw an
exception of that kind, this is not the way to document something like this.
Line 541: except se.StorageException:
Line 542: raise se.VolumesZeroingError(path)
Line 543:
Line 544: if version in VERS_METADATA_LV:
--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
