Dan Kenigsberg has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 14: (2 inline comments)
....................................................
File vdsm/storage/glusterVolume.py
Line 31: volPort = "0"
Line 32:
Line 33: imgFilePath = self.getVolumePath()
Line 34: imgFilePath_list = imgFilePath.rsplit("/")
Line 35: imgFileRelPath = "/".join(imgFilePath_list[4:])
I meant that you could build
/rhev/data-center/mnt/glusterSD/vm-vdsm-de-1:dpkvol3, find its len(), and drop
it from the path.
However, in a second thought,
"/".join(imgFilePath_list[-4:])
with a proper comment would be even better.
Line 36:
Line 37: glusterPath = volname + '/' + imgFileRelPath
Line 38:
Line 39: return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path':
glusterPath,
....................................................
File vdsm/storage/storageServer.py
Line 248: class GlusterFSConnection(MountConnection):
Line 249:
Line 250: def _getLocalPath(self):
Line 251: return os.path.join(
Line 252: self.localPathBase, "glusterSD",
that was my suggestion. I did not look deeply into the possible side effects,
but the code would be nicer.
Line 253: self._remotePath.replace("_", "__").replace("/", "_"))
Line 254:
Line 255:
Line 256: class NFSConnection(object):
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
