Dan Kenigsberg has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 248: class GlusterFSConnection(MountConnection):
Line 249: 
Line 250:     def _getLocalPath(self):
Line 251:         return os.path.join(
Line 252:             self.localPathBase, "glusterSD",
I have a vague memory of Saggi hating this import. Let us not infuriate him.

But wouldn't

 o.p.join(MountConnection.mountBasePath, "glusterSD")

be just as good?
Line 253:             self._remotePath.replace("_", "__").replace("/", "_"))
Line 254: 
Line 255: 
Line 256: class NFSConnection(object):


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to