Roy Golan has posted comments on this change. Change subject: catch libvirt timeout and return an error on setVmTicket ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/API.py Line 43: from vdsm.config import config Line 44: import ksm Line 45: Line 46: import supervdsm Line 47: from libvirtvm import TimeoutError Done Line 48: Line 49: # default message for system shutdown, will be displayed in guest Line 50: USER_SHUTDOWN_MESSAGE = 'System going down' Line 51: Line 575: except KeyError: Line 576: return errCode['noVM'] Line 577: except TimeoutError as tmo: Line 578: err = errCode['internalVdsmTimeout'] Line 579: err['exception'] = tmo Done I want to report the exception as it has relevant info for the engine which can't be described in the message - the timeout exception can be thrown with different causes. Line 580: return err Line 581: Line 582: def shutdown(self, delay=None, message=None): Line 583: """ -- To view, visit http://gerrit.ovirt.org/10285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
