Dan Kenigsberg has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 8: Line 9: Added _static folder to remove a sphinx-build warning, Line 10: updated incorrect reference in SPM.rst, modified Line 11: import statement in vm.py module. Generating docs Line 12: requires updating PYTHONPATH by making it pointing to both Could you have these PYTHONPATH changes within the "make htmlsctrict" target? Line 13: vdsm python package and vdsm_cli folder. Line 14: Line 15: Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=491467 .................................................... File vdsm/vm.py Line 32: from vdsm.config import config Line 33: import kaxmlrpclib Line 34: from logUtils import SimpleLogAdapter Line 35: import libvirt Line 36: import vdscli I am afraid that this is not an acceptable fix - we need the "from vdsm" during runtime. Line 37: Line 38: DEFAULT_BRIDGE = config.get("vars", "default_bridge") Line 39: Line 40: DISK_DEVICES = 'disk' -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
