Dan Kenigsberg has posted comments on this change. Change subject: doc: Solved sphinx-build import errors. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) Thanks for the new revision! .................................................... File doc/create_sl.sh Line 1: #!/bin/bash Line 2: Line 3: # Adds a symoblic link for vdscli in vdsm if not present. Line 4: VDSCLI=$(readlink -f "../vdsm/vdscli.py") Line 5: if [ ! -e $VDSCLI ] ; then still using unquoted variable Line 6: ln -s ../vdsm_cli/vdscli.py $VDSCLI .................................................... File doc/Makefile Line 11: PAPEROPT_a4 = -D latex_paper_size=a4 Line 12: PAPEROPT_letter = -D latex_paper_size=letter Line 13: ALLSPHINXOPTS = -d $(BUILDDIR)/doctrees $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) . Line 14: Line 15: export PYTHONPATH=../vdsm this seems a bit too broadly effective. I'd prefer setting a more specific SPHINXBUILD = PYTHONPATH=../vdsm:$$PYTHONPATH sphinx-build if it is indeed needed. Line 16: Line 17: .PHONY: help clean html htmlstrict dirhtml pickle json htmlhelp qthelp latex changes linkcheck doctest Line 18: Line 19: help: -- To view, visit http://gerrit.ovirt.org/11652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I836210fa5bbd844c20b3b5444be24cd9fa4023e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
