Hunt Xu has posted comments on this change.
Change subject: netinfo: get an interface using one of IP addresses assgined to
it
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 88: last = self.server.lastClient
Line 89: lastserver = self.server.lastServerIP
Line 90: return {'management_ip': self.serverIP,
Line 91: 'lastClient': last,
Line 92: 'lastClientIface': getIfaceByIP(lastserver)}
Actually I don't know either. However I'm just trying to keep my codes don't
break the existing ones.
Line 93:
Line 94: def _getKeyCertFilenames(self):
Line 95: """
Line 96: Get the locations of key and certificate files.
Line 113: def log_request(self, code='-', size='-'):
Line 114: """Track from where client connections are coming."""
Line 115: self.server.lastClient = self.client_address[0]
Line 116: self.server.lastClientTime = time.time()
Line 117: self.server.lastServerIP =
self.server.socket.getsockname()[0]
Done
It was a mistake. What I want is to log the server IP of each request, thus
should be self.request.getsockname()[0]. This differs from the sele.serverIP
which might be 0.0.0.0 or ::
Line 118: # FIXME: The editNetwork API uses this log file to
Line 119: # determine if this host is still accessible. We use
a
Line 120: # file (rather than an event) because editNetwork is
Line 121: # performed by a separate, root process. To clean
this
--
To view, visit http://gerrit.ovirt.org/11519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I239f92c527524e5651f51712841c3eafcf659e53
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
