Mark Wu has posted comments on this change.
Change subject: netinfo: get an interface using one of IP addresses assgined to
it
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/BindingXMLRPC.py
Line 88: last = self.server.lastClient
Line 89: lastserver = self.server.lastServerIP
Line 90: return {'management_ip': self.serverIP,
Line 91: 'lastClient': last,
Line 92: 'lastClientIface': getIfaceByIP(lastserver)}
Until anyone help me understand the reason, I can't review it. It doesn't
make sense for me to improve it if it's useless.
Line 93:
Line 94: def _getKeyCertFilenames(self):
Line 95: """
Line 96: Get the locations of key and certificate files.
--
To view, visit http://gerrit.ovirt.org/11519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I239f92c527524e5651f51712841c3eafcf659e53
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
