Saggi Mizrahi has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/supervdsm.py Line 194: def launch(self): Line 195: self._firstLaunch = False Line 196: self._start() Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) No reason to retry at all. Kill if launch fails. The user should be responsible for retries Line 199: except: Line 200: self.kill() Line 201: self.launch() Line 202: -- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
