Yaniv Bronhaim has posted comments on this change. Change subject: After fail to connect to supervdsm more than 3 time restart the process ......................................................................
Patch Set 1: (1 inline comment) we still have kill and launch .. but not in a function :) i didn't imagine that the socket can get deleted or not being created when we start a process by manager object.. so if we can't connect we have to restart. .................................................... File vdsm/supervdsm.py Line 197: try: Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3) Line 199: except: Line 200: self.kill() Line 201: self.launch() its that or getting into panic and let respawn to take care of it. what do we prefer? Line 202: Line 203: def __getattr__(self, name): Line 204: return ProxyCaller(self, name) Line 205: -- To view, visit http://gerrit.ovirt.org/11932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
