ShaoHe Feng has posted comments on this change.
Change subject: Make HSM service self containted
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
after this patch, will both HSM service and vdsm service depend on vdsm-python
package?
....................................................
File vdsm/storage/Makefile.am
Line 67: mount.py \
Line 68: multipath.py \
Line 69: securable.py \
Line 70: storage_exception.py
Line 71:
add these file to dsm-python package in vdsm.spec file?
Line 72:
Line 73:
Line 74: EXTRA_DIST = \
Line 75: 12-vdsm-lvm.rules
....................................................
File vdsm/storage/storage_rpcserver.py
Line 10:
Line 11: class RequestHandler(SimpleXMLRPCRequestHandler):
Line 12: rpc_paths = ('/RPC2',)
Line 13:
Line 14: storage_server = SimpleXMLRPCServer(("localhost", 8000),
localhost? we should call the storage_server remotely.
should 8000 be set in the configure file?
Line 15: requestHandler=RequestHandler)
Line 16:
Line 17: os.setgid(36)
Line 18: os.setuid(36)
--
To view, visit http://gerrit.ovirt.org/11502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b842f6e97e7506d66226bca088e1b5296be26c4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
