ShaoHe Feng has posted comments on this change.
Change subject: Make HSM service self containted
......................................................................
Patch Set 4: (1 inline comment)
It make things easy that normal VDSM service and the storage service depend on
the same vdsm-python.
-1 just for you forget to add config.py.in
....................................................
File vdsm/storage/storage_rpcserver.py
Line 11:
Line 12: class RequestHandler(SimpleXMLRPCRequestHandler):
Line 13: rpc_paths = ('/RPC2',)
Line 14:
Line 15: storagerpc_port = config.get('addresses', 'storagerpc_port')
storagerpc_port was not in config.py.in
Line 16: storage_server = SimpleXMLRPCServer(("localhost", storagerpc_port),
Line 17: requestHandler=RequestHandler)
Line 18:
Line 19: os.setgid(36)
--
To view, visit http://gerrit.ovirt.org/11502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b842f6e97e7506d66226bca088e1b5296be26c4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
