Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Try to reconnect on vmchannel after timeout
......................................................................
Patch Set 2: No score; No score
(1 inline comment)
....................................................
File vdsm/guestIF.py
Line 272: if self.guestStatus not in ("Powered down",
"RebootInProgress"):
Line 273: self.log.log(logging.TRACE, "Guest connection timed out")
Line 274: self.guestStatus = None
Line 275: self.log.debug("Attempting to reconnect to channel after
timeout")
Line 276: self._connect()
well, that's really not feasible - it may be that you have the guest installed
for some time and only eventually you install the guest agent. That's why we
need to retry all the time. Checking the socket is pretty cheap
Line 277:
Line 278: def _clearReadBuffer(self):
Line 279: self._buffer = []
Line 280: self._bufferSize = 0
--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
