Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Try to reconnect on vmchannel after errors
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File vdsm/vmChannels.py
Line 61: self.log.exception("Exception on read callback.")
Line 62:
Line 63: def _prepare_reconnect(self, fileno):
Line 64: self._epoll.unregister(fileno)
Line 65: obj = self._channels[fileno]
obj = self._channels.pop(fileno)
Line 66: del self._channels[fileno]
Line 67: try:
Line 68: fileno = obj['setup_cb'](obj['opaque'])
Line 69: except:
Line 67: try:
Line 68: fileno = obj['setup_cb'](obj['opaque'])
Line 69: except:
Line 70: self.log.exception("An error occurred in the setup
callback "
Line 71: "fileno: %d.", fileno)
we should not ignore the possible error
Line 72: self._unconnected[fileno] = obj
Line 73:
Line 74: def _handle_timeouts(self):
Line 75: """
Line 120: else:
Line 121: raise
Line 122: self._add_channels.pop(fileno, None)
Line 123: self._unconnected.pop(fileno, None)
Line 124: self._reconnect_cooldown(fileno, None)
self._reconnect_cooldown.pop(…)
Line 125: self._channels.pop(fileno, None)
Line 126: self.log.debug("fileno %d was removed from listener.",
fileno)
Line 127: self._del_channels = []
Line 128:
--
To view, visit http://gerrit.ovirt.org/11977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
