Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init: remove legacy judgment code ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 8: Line 9: Judging whether vdsm is registered by checking whether the certificates Line 10: exist is legacy. With commit b94937438 there would always be Line 11: certificates for vdsm(first in the rpm, generated during startup with Line 12: commit 31f4565bd). This patch also merges two if isOvirt judgment a general rule of thumb is that when you have the "also" mentioned in the commit message, the commit can bit split. In fact, having these two changes in the same commit has confused me! Would you please split them apart? Removing the legacy code is clearly good, but I am not sure about the second change. Line 13: together to tidy the code and the certificates validation would be Line 14: performed only when they exist in case configure_libvirt is called Line 15: individually(not as a part in vdsm startup). Line 16: -- To view, visit http://gerrit.ovirt.org/12875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51f73576975b13bcdaa110f679c3d5596ae5210 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
