Alon Bar-Lev has posted comments on this change. Change subject: vdsmd.init: remove legacy judgment code ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 10: exist is legacy. With commit b94937438 there would always be Line 11: certificates for vdsm(first in the rpm, generated during startup with Line 12: commit 31f4565bd). The certificates validation would be performed only Line 13: when they exist in case configure_libvirt is called individually(not as Line 14: a part in vdsm startup). I don't understand... if certificate is always available, why bother validating it? And if we want to validate it, why not always validate it? Thanks! Line 15: Line 16: Change-Id: If51f73576975b13bcdaa110f679c3d5596ae5210 -- To view, visit http://gerrit.ovirt.org/12875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If51f73576975b13bcdaa110f679c3d5596ae5210 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
