Mark Wu has posted comments on this change.
Change subject: trivial: Use os.uname to get kernel version insteaf of reading
proc files
......................................................................
Patch Set 2: (1 inline comment)
It seems that it's a good practice to leave a cover message to highlight the
change from last version and something for reviewers to note. The comments
inline are easily ignored.
....................................................
File vdsm/caps.py
Line 313: def kernelDict():
Line 314: try:
Line 315: ret = os.uname()
Line 316: ver, rel = ret[2].split('-', 1)
Line 317: t = ret[3].split()[2:]
It's explained in the comments in patch set v1:
The build date is auto generated by kernel build script. So i think it's safe
to use on try-except block. Is this reason acceptable?
Reply ...Reply 'Done'
Please see
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/mkcompile_h#n56
Line 318: del t[4] # Delete timezone
Line 319: t = time.mktime(time.strptime(' '.join(t)))
Line 320: except:
Line 321: ver, rel, t = '0', '0', '0'
--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
