Dan Kenigsberg has posted comments on this change. Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files ......................................................................
Patch Set 2: I usually take great care to see read all responses to my comments. I do not know how I've missed yours, and I apologize. However, as I've said, I have a vague memory of someone using a non-default kernel and exploding on this triviality. This might have been before there was any try-except protection, and there's nothing really to be afraid of now - but I do not quite understand the eagerness for a change per se. I prefer that you keep the separation, but I am not adamant about it. -- To view, visit http://gerrit.ovirt.org/12874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
