Dan Kenigsberg has posted comments on this change. Change subject: Seperating supervdsm log to supervdsm.log file ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/supervdsmServer.py Line 356: try: Line 357: f = "%(threadName)s::%(levelname)s::%(asctime)s::%(module)s::" \ Line 358: "%(lineno)d::%(name)s::(%(funcName)s) %(message)s" Line 359: logfile = P_VDSM_LOG + "/suprevdsm.log" Line 360: logging.basicConfig(filename=logfile, this time, Alon is completely right ;-) It would be much better to let end users control the place and level of the log, which may be easily achieved by having /etc/vdsm/svdsm.logger.conf. In any case, you should drop SuperVdsm references from logger.conf. Line 361: level=logging.DEBUG, Line 362: format=f,) Line 363: except: Line 364: logging.basicConfig(filename='/dev/stdout', filemode='w+', -- To view, visit http://gerrit.ovirt.org/12940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e5fb4a2cd5421671f942120b6718c1bb20b9e60 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches