Dan Kenigsberg has posted comments on this change. Change subject: Seperating supervdsm log to supervdsm.log file ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) > I don't think there is a need for separate logger.conf, we can have single > logger conf with both settings. Alon, I thought that you - above all other - would actually like this separation. It supports YOUR svdsm agenda. I think that it's actually good to separate the files, as it makes it hard for someone configuring logger.conf to make a mistake that affects the root-user process. .................................................... File vdsm/Makefile.am Line 85: vdsm-store-net-config Line 86: Line 87: nodist_noinst_DATA = \ Line 88: logger.conf \ Line 89: svdsm.logger.conf \ keep ordering please. Line 90: mom.conf \ Line 91: sudoers.vdsm \ Line 92: vdsm-logrotate.conf \ Line 93: vdsm-restore-net-config.init \ -- To view, visit http://gerrit.ovirt.org/12940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e5fb4a2cd5421671f942120b6718c1bb20b9e60 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
