Shu Ming has posted comments on this change.

Change subject: getAllTasksList\Status with spUUID retrieves info only if host 
is the SPM
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: getAllTasksList\Status with spUUID retrieves info only if host is the 
SPM
Line 8: 
Line 9: Request for tasks statuses or list with the optional argument spUUID
Line 10: will return only if the host is the SPM. Without spUUID param vdsm 
will return
Line 11: all tasks it can find.
I am really confusing about how the spUUID option will affect the output of 
getAllTasksList\Status.  1) If spUUID is given and the host is SPM,  will the 
tasks on the other hosts(non-spm) be returned? 2) If spUUID is not given,  will 
all the tasks on spm and non-spm hosts be returned?   These questions go to a 
generic questions:  Do the tasks belong to hosts or belong to storage pool?
Line 12: 
Line 13: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=880547
Line 14: Signed-off-by: Yaniv Bronhaim <[email protected]>


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to