Dan Kenigsberg has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM ......................................................................
Patch Set 12: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 2035: taskStatus = self.taskMng.getTaskStatus(taskID=taskID) Line 2036: return dict(taskStatus=taskStatus) Line 2037: Line 2038: @public Line 2039: def getAllTasksStatuses(self, spUUID=None): Why was "options=None" dropped from the function's signature? I do not see how this is related to the purpose of this patch. It may well be that we need to drop it - and we may even be able to do it since no Engine ever used it - but adding it to this disputed patch only complicates things for me. Line 2040: """ Line 2041: Gets the status of all public tasks. Line 2042: Line 2043: :param spUUID: if specified returns pool specific tasks, -- To view, visit http://gerrit.ovirt.org/12517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel P. Berrange <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
