Eduardo has posted comments on this change. Change subject: Encode '=' when persisting the Task. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/task.py Line 80: ROLLBACK_SENTINEL = "rollback sentinel" Line 81: Line 82: Line 83: def _eq_encode(s): Line 84: return s.replace(KEY_SEPARATOR, KEY_SEPARATOR_ENCODED) You are absolutely right. This patch not wants to be a serious serialization, only to expand the string space that can be used in the tasks. If we need a good encode we should use a shelf library. Meanwhile this patch solves the bug and alleviates the situation since are less strings containing '_eq_' than '=' . Line 85: Line 86: Line 87: def _eq_decode(s): Line 88: return s.replace(KEY_SEPARATOR_ENCODED, KEY_SEPARATOR) -- To view, visit http://gerrit.ovirt.org/13128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d28974d3953aafaf4b5e5f1a25363d22b50c3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dafna Ron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
