Dan Kenigsberg has posted comments on this change.
Change subject: Encode '=' when persisting the Task.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/task.py
Line 643: field = _eq_encode(field)
Line 644: value = _eq_encode(value)
Line 645: except ValueError as e:
Line 646: cls.log.warning("Object %s: Cannot encode field
%s or "
Line 647: "value %s. Skipping field." %
come to think of it, you must match the number of format args!
also, we prefer log.warning("Object %s", bla) over log.warning("Object %s" %
bla)
Line 648: (obj, field, value), e)
Line 649: else:
Line 650: lines.append("%s %s %s" % (field, KEY_SEPARATOR,
value))
Line 651: return lines
--
To view, visit http://gerrit.ovirt.org/13128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735d28974d3953aafaf4b5e5f1a25363d22b50c3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dafna Ron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
