Dan Kenigsberg has posted comments on this change.
Change subject: dsaversion: Adding new Name Release Version field
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/dsaversion.py.in
Line 26: # FIXME: As soon as we can provide a long version/release to
oVirt-Engine
Line 27: # remove from vdsm.spec the sed to replace the below macros
Line 28: software_version = "@PACKAGE_VERSION@"
Line 29: software_revision = "@PACKAGE_RELEASE@"
Line 30: nvr = "%s @PACKAGE_VERSION@.@PACKAGE_RELEASE@" % version_name
nvr is an ugly name. I know that I raised it, but it's not an excuse ;-)
in rpm world, nvr always looks like
vdsm-4.10.444-12.f18
No Snow Men.
Line 31:
Line 32: version_info = {
Line 33: 'version_name': version_name,
Line 34: 'software_version': software_version,
Line 32: version_info = {
Line 33: 'version_name': version_name,
Line 34: 'software_version': software_version,
Line 35: 'software_revision': software_revision,
Line 36: 'nvr': nvr,
I do not see any reason to expose this to Engine.
Line 37: 'supportedENGINEs': ['3.0', '3.1'],
Line 38: 'supportedProtocols': ['2.2', '2.3'],
Line 39: 'clusterLevels': ['3.0', '3.1', '3.2'],
--
To view, visit http://gerrit.ovirt.org/12952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b6a28e378c4090595e823588dbbe583a38a353
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
