Dan Kenigsberg has posted comments on this change.
Change subject: dsaversion: Adding software_release
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/dsaversion.py.in
Line 26: # FIXME: As soon as we can provide a long version/release to
oVirt-Engine
Line 27: # remove from vdsm.spec the sed to replace the below macros
Line 28: software_version = "@PACKAGE_VERSION@"
Line 29: software_revision = "@PACKAGE_RELEASE@"
Line 30: software_release = "@PACKAGE_VERSION@.@PACKAGE_RELEASE@"
sorry, I still dislike the name. it's not just the release. it's version AND
release. "rpmVR" may be more exact.
Line 31:
Line 32: version_info = {
Line 33: 'version_name': version_name,
Line 34: 'software_version': software_version,
--
To view, visit http://gerrit.ovirt.org/12952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b6a28e378c4090595e823588dbbe583a38a353
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
