Dan Kenigsberg has posted comments on this change.
Change subject: Optimize netinfo.networks.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
I know that I've already acked this, but in a second look - it's confusing.
....................................................
File lib/vdsm/netinfo.py
Line 89: 'red': { 'iface': 'red', 'bridged': False } }
Line 90: """
Line 91: nets = {}
Line 92: conn = libvirtconnection.get()
Line 93: allNets = ((netObj, netObj.name()) for netObj in
conn.listAllNetworks(0))
here it's called "netObj"
Line 94: for net, netname in allNets:
Line 95: if netname.startswith(LIBVIRT_NET_PREFIX):
Line 96: netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 97: nets[netname] = {}
Line 90: """
Line 91: nets = {}
Line 92: conn = libvirtconnection.get()
Line 93: allNets = ((netObj, netObj.name()) for netObj in
conn.listAllNetworks(0))
Line 94: for net, netname in allNets:
and here - it's "net". that's just confusing.
Line 95: if netname.startswith(LIBVIRT_NET_PREFIX):
Line 96: netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 97: nets[netname] = {}
Line 98: xml = minidom.parseString(net.XMLDesc(0))
--
To view, visit http://gerrit.ovirt.org/13159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd332819363c4399335358686e19d6a1dc3b45e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jarod.w <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
