Dan Kenigsberg has submitted this change and it was merged. Change subject: Optimize netinfo.networks. ......................................................................
Optimize netinfo.networks. Currently netinfo.networks is doing three trips to libvirt: - libvirtmod.virNetworkLookupByName - libvirtmod.virConnectListNetworks - libvirtmod.virNetworkGetXMLDesc With this change, we reduce it to: - libvirtmod.virNetworkGetXMLDesc - libvirtmod.virConnectListAllNetworks Testing ======== In [185]: %timeit foo() 100 loops, best of 3: 4.45 ms per loop %timeit netinfo.networks() %100 loops, best of 3: 7.55 ms per loop Change-Id: I2cd332819363c4399335358686e19d6a1dc3b45e Signed-off-by: Antoni S. Puimedon <[email protected]> --- M lib/vdsm/netinfo.py 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd332819363c4399335358686e19d6a1dc3b45e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jarod.w <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
