Dan Kenigsberg has submitted this change and it was merged. Change subject: Encode '=' when persisting the Task. ......................................................................
Encode '=' when persisting the Task. "For a reason unknown (to me), task.py does not use pickle to persist its data to file. We cannot fix that without breaking backward-compatibility." Danken, circa 2012. Caveat Emptor: This patch expands the string space that can be encoded when a task is dumped and not tries to solve all task serialization issues. Since the old code ignored fields that can't be encoded, we continue to assume that doing this no harms the system. Based on this assumption we are disregarding the case of a task load in a host with this code when the dump contains real '_eq_'. Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=915068 Change-Id: I735d28974d3953aafaf4b5e5f1a25363d22b50c3 Signed-off-by: Eduardo <[email protected]> --- M vdsm/storage/task.py 1 file changed, 25 insertions(+), 8 deletions(-) Approvals: Daniel Paikov: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I735d28974d3953aafaf4b5e5f1a25363d22b50c3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dafna Ron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
