Ayal Baron has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 927: Get the set of all images uuids in the SD.
Line 928: """
Line 929: vols = self.getAllVolumes() # {volName: ([imgs], parent)}
Line 930: images = set()
Line 931: for imgs, parent in vols.itervalues():
again, currently vdsClient reports the broken images but does not distinguish
them from ones that are valid.
I think we should not stop reporting these but make the distinction.
I'll mark -1 so that my comment won't be ignored again.
Line 932: images.update(imgs)
Line 933: return images
Line 934:
Line 935: def rmDCVolLinks(self, imgPath, volsImgs):
--
To view, visit http://gerrit.ovirt.org/12938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028dabbf1a0b39177d0c52222cae177f5123442f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
