Eduardo has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 927: Get the set of all images uuids in the SD.
Line 928: """
Line 929: vols = self.getAllVolumes() # {volName: ([imgs], parent)}
Line 930: images = set()
Line 931: for imgs, parent in vols.itervalues():
> will this cause getAllImages in vdsClient to not display broken images?
yes.
>I wonder if we shouldn't change the interface and actually display those in a
>clear fashion.
Already agreeded with you to discard this option since is not backwards
compatible.
>Alternatively, expose a new verb in vdsClient to retrieve the partial images.
Already agreed with you that we will add garbage collection.
You objected that GC will be done manually or started by the engine, therefore
objected the new CLI interface.
Anyway the addition of the CLI interface or GC is not required for the BZ
solution and was postponed.
Line 932: images.update(imgs)
Line 933: return images
Line 934:
Line 935: def rmDCVolLinks(self, imgPath, volsImgs):
--
To view, visit http://gerrit.ovirt.org/12938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028dabbf1a0b39177d0c52222cae177f5123442f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
