Haim Ateya has posted comments on this change.

Change subject: Checking syslog availability before starting vdsm
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 445: start() {
Line 446:     local ret_val
Line 447: 
Line 448:     if ! syslog_available; then
Line 449:       log_failure_msg "Cannot communicate with see log. Check 
rsyslog.conf"
cannot communicate with what? please improve error message, also, will I see 
the print in the console when starting the service?
Line 450:       return 1
Line 451:     fi
Line 452: 
Line 453:     python @VDSMDIR@/hooks.pyc before_vdsm_start


--
To view, visit http://gerrit.ovirt.org/13547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60d0537f67da3cf81477760ccb3760a103dc15ac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to