Dan Kenigsberg has posted comments on this change.
Change subject: Checking syslog availability before starting vdsm
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vdsmd.init.in
Line 136: return 0
Line 137: }
Line 138:
Line 139: syslog_available() {
Line 140: [[ -x "$SYS_LOG_PATH" ]]
I'd hide the error code and the path definition within this function - they are
of no interest to anything else in this overbloated script.
Line 141: }
Line 142:
Line 143: libvirt_should_use_upstart() {
Line 144: [[ -x /sbin/initctl ]]
Line 466: log_failure_msg "$prog: failed to reconfigure libvirt"
Line 467: return $ret_val
Line 468: fi
Line 469:
Line 470: start_needed_srv && start_libvirtd
it feels much more natural to put the new test here. syslog is just another
required service.
Line 471: ret_val=$?
Line 472: if [ $ret_val -ne 0 ]
Line 473: then
Line 474: log_failure_msg "$prog: one of the dependent services did not
start, error code $ret_val"
--
To view, visit http://gerrit.ovirt.org/13547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60d0537f67da3cf81477760ccb3760a103dc15ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
