Shu Ming has posted comments on this change.
Change subject: Make sr-iov hook use interface instead of hostdev
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_hooks/sriov/after_vm_destroy.py
Line 44: with open(path, 'r') as f:
Line 45: for line in f:
Line 46: nicAddr = line.split('=')
Line 47: if nicAddr[0] in nics:
Line 48: returnDeviceToHost(nicAddr[1],
nicAddr[2].strip('\n'))
Is it necessary to remove the SriovElement from the VM's xml file that is
created in before_vm_start.py?
Line 49: else:
Line 50: lines += line
Line 51:
Line 52: with open(path, 'w') as f:
....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 71: </source>
Line 72: # TODO: Check if we omit the mac address to have libvirt
auto-generate
Line 73: # it
Line 74: <mac address='4:54:00:6d:90:02'/>
Line 75: # TODO: This should be set only if connected to this kind of
switch.
We may create different virtualport type based on the shell variable value in
os..environ for different switches the virtual port is attched to like qbh,
opensiwtch &etc.
Line 76: <virtualport type='802.10bh'>
Line 77: <parameters proileid='foobar'/>
Line 78: </virtualport>
Line 79: </interface>
--
To view, visit http://gerrit.ovirt.org/13541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Yasny <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
