Mark Wu has posted comments on this change.
Change subject: Make sr-iov hook use interface instead of hostdev
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 141:
Line 142: sys.stderr.write('sriov: VF %s xml: %s\n' %
Line 143: (nic, interface.toxml()))
Line 144: devices.appendChild(interface)
Line 145: chown(devpath)
Curious about if 'chown' is still necessary. I don't have sriov enabled hw at
hand. It's also great if you could give me some docs stating it's necessary. I
didn't find that requirement after a research. Thanks!
Line 146: writeSriovCache(nic, addr, devpath)
Line 147: else:
Line 148: sys.stderr.write('sriov: cannot find nic "%s",
aborting\n' %
Line 149: nic)
--
To view, visit http://gerrit.ovirt.org/13541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Yasny <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
