Vered Volansky has uploaded a new change for review. Change subject: Remove unnecessary storage log messages from logs ......................................................................
Remove unnecessary storage log messages from logs 1. Removed all storage log messages from syslog. 2. Removed "namespace already exists" log messages from vdsm log since they they are not interesting. These messages originated from resourceManager.registerNamespace(). 3. Previously, above method errors were all caught and treated as the KeyError, which means non-KeyError exceptions were swallowed. Now KeyErrors are ignored intentionally, and other potential exceptions are not caught at all, i.e., not swallowed anymore. Bug-Url: https://bugzilla.redhat.com/920074 ../vdsm_cli/ Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Signed-off-by: Vered Volansky <[email protected]> --- M vdsm/logger.conf.in M vdsm/storage/blockSD.py M vdsm/storage/sd.py 3 files changed, 7 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/13617/1 diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in index 0a4622f..824e169 100644 --- a/vdsm/logger.conf.in +++ b/vdsm/logger.conf.in @@ -20,7 +20,7 @@ [logger_Storage] level=DEBUG -handlers=syslog,logfile +handlers=logfile qualname=Storage propagate=0 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 9809bf4..0eeb639 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -447,9 +447,8 @@ try: rmanager.registerNamespace(lvmActivationNamespace, lvmActivationFactory) - except Exception: - self.log.warn("Resource namespace %s already registered", - lvmActivationNamespace) + except KeyError: + pass @classmethod def metaSize(cls, vgroup): diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py index 73154cc..369d2ce 100644 --- a/vdsm/storage/sd.py +++ b/vdsm/storage/sd.py @@ -368,17 +368,15 @@ try: rmanager.registerNamespace(imageResourcesNamespace, imageResourceFactory) - except Exception: - self.log.warn("Resource namespace %s already registered", - imageResourcesNamespace) + except KeyError: + pass volumeResourcesNamespace = getNamespace(self.sdUUID, VOLUME_NAMESPACE) try: rmanager.registerNamespace(volumeResourcesNamespace, rm.SimpleResourceFactory()) - except Exception: - self.log.warn("Resource namespace %s already registered", - volumeResourcesNamespace) + except KeyError: + pass def produceVolume(self, imgUUID, volUUID): """ -- To view, visit http://gerrit.ovirt.org/13617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
