Dan Kenigsberg has posted comments on this change. Change subject: Remove unnecessary storage log messages from logs ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 446: LVM_ACTIVATION_NAMESPACE) Line 447: try: Line 448: rmanager.registerNamespace(lvmActivationNamespace, Line 449: lvmActivationFactory) Line 450: except KeyError: Dropping the "except Exception" line is wonderful. However: registerNamespace() is a quite a complex function, calling plenty of other functions. KeyError may stem from various unexpected reasons. It is a bit frightening to just ignore them all. If there's an expected failure someone, it is better to swallow it specifically. Line 451: pass Line 452: Line 453: @classmethod Line 454: def metaSize(cls, vgroup): -- To view, visit http://gerrit.ovirt.org/13617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc0fa5ca50e4eb78d62fd3cdc8b09723486bcaa0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
