Dan Kenigsberg has posted comments on this change. Change subject: Make sr-iov hook use interface instead of hostdev ......................................................................
Patch Set 7: I would prefer that you didn't submit this Toni, I am a bit worried about "After installing vdsm, libvirt loses the ability to attach devices/images that belong to root." Could you give some information about the failure? Which of vdsm's configurations cause this? Is it "dynamic_ownership 0"? writeSriovCache() is clearly a messy racy function, I'd like to kill it. But could you split this into a follow up patch? I mean, let's have a patch to make this work for a single VM started, and another patch making the whole thing reentrant. -- To view, visit http://gerrit.ovirt.org/13541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f88a8400fe4d230c0877428afef62df8e397db Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Yasny <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
